Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETL-670] Setup and run pre-commit for all files #122

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[ETL-670] Setup and run pre-commit for all files #122

merged 1 commit into from
Jul 3, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. No linting was set up in the precommit config

Solution:

  1. Set up the black formatter and isort to run in pre-commit

@BryanFauble BryanFauble requested a review from a team as a code owner July 2, 2024 22:29
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
45 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarCloud

BryanFauble
BryanFauble commented Jul 2, 2024
View reviewed changes
pyproject.toml
@@ -0,0 +1,7 @@
[tool.black]
line-length = 88
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

88 is the default, but we can swap to whatever. 88 is what the SynapsePythonClient is using

rxu17
rxu17 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@rxu17 rxu17 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and taking care of this (forgot to include in the compare parquet PR)! LGTM!

@BryanFauble BryanFauble merged commit 99fb889 into main Jul 3, 2024
17 checks passed
@BryanFauble BryanFauble deleted the etl-670-pre-commit branch July 3, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxu17 rxu17 rxu17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BryanFauble @rxu17